-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search Sessions] omit searchSessionId from the initialState, explicitly pause refreshInterval in restoreState #88650
[Search Sessions] omit searchSessionId from the initialState, explicitly pause refreshInterval in restoreState #88650
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
…it-search-session-id-in-initial-state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana App owned code LGTM, tested locally in Chrome, searchSession at intialState is successfully omitted in Discover 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentation team changes LGTM. Code only review, but will look into testing the full set of features with #81707.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…tly pause refreshInterval in restoreState (elastic#88650)
Summary
Closes #88567 #88568
This pr closes two-issue around restoring a search session in Discover and Dashboard:
1.
searchSessionId
should be omitted ininitialState
We save two states into a search session saved object:
restoreState
initialState
These states are used when navigating from management to an App. By default
restoreState
is used to restore a session.We use
initialState
when we know there is no session to restore, for example, in case the search session is in theERROR
orEXPIRED
state.initialState
should not containsearchSessionId
, otherwise search requests will error out.How to test
When saving a session there should be no
searchSessionId
insideinitialState
in a request save request payload.To test end-to-end needs #81707. In case the search is is in the
ERROR
orEXPIRED
state, navigating to it should just restart a search.2. refresh interval should be explicitly
paused
when generatingrestoreState
for dashboard.If there is no
refreshInterval
in the URL dashboard picks up whatever is saved in the dashboard SO.