[FTR] Use new ES client instead of legacyEs service #88720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
afharo
force-pushed
the
functional-tests/migrateToNewEsClient
branch
from
07a3a36 to
2a45520
Compare
mshustov
reviewed
Jan 20, 2021
| @@ -256,6 +258,7 @@ export default function ({ getService }) { | |||
| ) | |||
| .expect(400) | |||
| .then((resp) => { | |||
| // eslint-disable-next-line no-console | |||
There was a problem hiding this comment.
The log line I added was just for debugging so it shouldn't have been commited.
There was a problem hiding this comment.
I'll remove them then. Thanks for confirming!
mshustov
reviewed
Jan 20, 2021
| /* | ||
| * Create a single-level array with strings for all the paths to values in the | ||
| * source object, up to 3 deep. Going deeper than 3 causes a bit too much churn | ||
| * in the tests. | ||
| */ | ||
| function flatKeys(source) { | ||
| const recursivelyFlatKeys = (obj, path = [], depth = 0) => { | ||
| function flatKeys(source: any) { |
There was a problem hiding this comment.
Record or object instead of any?
mshustov
approved these changes
Jan 20, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Jan 20, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 20, 2021
Fixed merge conflicts from elastic#88720.
afharo
added a commit
that referenced
this pull request
Jan 20, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates all the functional tests owned by @elastic/kibana-core from
legacyEsto the servicees. At the same time, it migrates them from.jsto.tsto help with types in the future.Resolves #72442.
Checklist
Delete any items that are not applicable to this PR.
For maintainers