[Maps] fix users without access to Maps should not have the option to create them #88830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
thx for fixing.
we should also solve the case where the "visualize"-button is showing in Discover for geo-fields.
We could just not register the trigger when the user does not have priviliges
e.g.: something like
if (core.application.capabilities.maps.save) {
plugins.uiActions.addTriggerAction(VISUALIZE_GEO_FIELD_TRIGGER, visualizeGeoFieldAction);
} else {
plugins.visualizations.unRegisterAlias(APP_ID);
}
If we don't register the trigger, the visualize-button is no longer showing
thomasneirynck
approved these changes
Jan 25, 2021
| // unregisters the OSS alias | ||
| plugins.visualizations.unRegisterAlias(PLUGIN_ID_OSS); | ||
|
|
||
| if (core.application.capabilities.maps.show) { |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 25, 2021
… create them (elastic#88830) * [Maps] fix users without access to Maps should not have the option to create them * fix test message * wrap add geo field trigger in show capabilities check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jan 25, 2021
… create them (#88830) (#89209) * [Maps] fix users without access to Maps should not have the option to create them * fix test message * wrap add geo field trigger in show capabilities check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88723
This PR unregisters Maps visualization alias when a user does not have write permission to maps. This ensures the
Mapscard is not displayed in the visualize create menu when users do not have permission to create a map.