Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Sessions] Add searchSessionId to Vega's inspector #88839

Merged
merged 1 commit into from
Jan 21, 2021
Merged

[Search Sessions] Add searchSessionId to Vega's inspector #88839

merged 1 commit into from
Jan 21, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jan 20, 2021 •
edited
Loading

Part of #61738

While playing with search sessions I noticed that Vega uses inspector, but we don't pass searchSessionId into it

This pr add searchSessionId into Vega's inspector:

Screenshot 2021-01-20 at 14 55 11

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Jan 20, 2021
@Dosant Dosant marked this pull request as ready for review January 20, 2021 15:49
@Dosant Dosant requested review from a team and alexwizp January 20, 2021 15:49
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVega 60.6KB 61.7KB +1.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp
alexwizp approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stratoula
stratoula approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM! ❤️

@Dosant Dosant merged commit 05fcdd8 into elastic:master Jan 21, 2021
Dosant added a commit to Dosant/kibana that referenced this pull request Jan 21, 2021
@Dosant
[Search Sessions] Add searchSessionId to Vega's inspector (elastic#88839
ae55cdd 
)
@Dosant Dosant mentioned this pull request Jan 21, 2021
Merged
Dosant added a commit that referenced this pull request Jan 21, 2021
@Dosant
[Search Sessions] Add searchSessionId to Vega's inspector (#88839) (#…
0a7e498 
…88945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees
No one assigned
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dosant @kibanamachine @stratoula @alexwizp