Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Cleanup OSS code from visualizations wizard (#89092) #89409

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

stratoula
Copy link
Contributor

Backports the following commits to 7.x:

* Cleanup OSS code from visualizations wizard

* Remove unecessary translations

* Remove unused translation

* Fix functional test

* Disable the functional test for OSS

* Remove from oss correctly :D

* Fix ci
# Conflicts:
#	.github/CODEOWNERS
#	docs/developer/plugin-list.asciidoc
#	packages/kbn-optimizer/limits.yml
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lensOss 7 - -7
mapsOss 7 - -7
total -14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 855.6KB 855.6KB -1.0B
maps 2.6MB 2.6MB -3.0B
visualizations 58.3KB 57.2KB -1.1KB
total -1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 34.4KB 34.0KB -361.0B
lensOss 4.5KB - -4.5KB
maps 138.7KB 138.3KB -351.0B
mapsOss 4.2KB - -4.2KB
total -9.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit ddc2058 into elastic:7.x Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants