Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Stabilize accessibility tests for data frame analytics pages #89423

Merged
merged 4 commits into from
Jan 29, 2021
Merged

[ML] Stabilize accessibility tests for data frame analytics pages #89423

merged 4 commits into from
Jan 29, 2021

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jan 27, 2021 •
edited
Loading

Summary

Follow up to #88323, stabilizing accessibility tests on the data frame analytics wizard.

  • Removes the .leaflet-vega-container for the ignore selector in the a11y.ts as this class isn't applied to the vega visualization used for the scatterplot matrix in the data frame analytics pages
  • Fixes duplicate IDs on the 'select all' checkboxes of the includes field selection table
  • Adds an assert for the includes fields selection table to ensure the tests are always run after this element has been rendered.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@peteharverson peteharverson self-assigned this Jan 27, 2021
@peteharverson peteharverson requested a review from a team as a code owner January 27, 2021 14:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@pheyos
Copy link
Member

pheyos commented Jan 27, 2021 •
edited
Loading

Checking test stability

Commit level 8a9bbf4

Commit level f2c1d80

Commit level 3027f28

Commit level ffa0598

pheyos
pheyos approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.5MB 6.5MB +176.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pheyos
pheyos approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

@peteharverson peteharverson merged commit 827446b into elastic:master Jan 29, 2021
@peteharverson peteharverson deleted the ml-a11y-stabilize-dfa-tests branch January 29, 2021 09:15
@peteharverson peteharverson mentioned this pull request Jan 29, 2021
Merged
This was referenced Jan 29, 2021
Closed
Closed
peteharverson added a commit that referenced this pull request Jan 29, 2021
@peteharverson
[ML] Stabilize accessibility tests for data frame analytics pages (#8…
c6d8e34 
…9423) (#89691)

* [ML] Stabilize accessibility tests for data frame analytics pages

* [ML] Remove snapshot test after opening index pattern modal

* [ML] Remove snapshot test when index pattern modal opens

* [ML] Add back snapshot test at index pattern modal step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@myasonik myasonik myasonik approved these changes

Assignees

@peteharverson peteharverson

Labels
:ml Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes review v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @pheyos @kibanamachine @myasonik