Remove geo threshold alert type #89632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
release_note:breaking
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
20 tasks
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Jan 29, 2021
kindsun
force-pushed
the
remove-geo-threshold-alert
branch
from
3624f1c to
c09755e
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Geo threshold alert type since the major functionality of this alert type can be covered by Geo containment alerts. It will be much simpler moving forward focusing on enhancing a single alert type and building it out to handle multiple use cases.
cc @gmmorris Are you aware of any further complexity to removing an alert type resulting from modifications to
x-pack/plugins/stack_alerts/server/feature.ts? I seem to remember you bringing something up in a previous conversation around deprecation/removal ofstack_alerts. Since this feature is still behind an experimental flag, any normal issues with these changes may not apply here, just want to be sure though!