-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Combines Jest unit tests #89948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
jest-single-take2
branch
9 times, most recently
from
February 3, 2021 16:30
5401c9c
to
a425f3a
Compare
jenkins test this |
tylersmalley
force-pushed
the
jest-single-take2
branch
6 times, most recently
from
February 8, 2021 18:31
94aaa10
to
bc501d8
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
jest-single-take2
branch
from
February 8, 2021 21:14
bc501d8
to
f9c8d97
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tylersmalley
added
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
v8.0.0
labels
Feb 8, 2021
This is ready - I reverted the changes to always run code coverage and will address those issues separately. cc: @dmlemeshko |
spalger
approved these changes
Feb 9, 2021
wayneseymour
reviewed
Feb 9, 2021
jbudz
approved these changes
Feb 9, 2021
wayneseymour
approved these changes
Feb 9, 2021
Backport result
|
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Feb 9, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # jest.config.oss.js # src/dev/code_coverage/shell_scripts/extract_archives.sh # test/scripts/jenkins_unit.sh # test/scripts/jenkins_xpack.sh # vars/kibanaCoverage.groovy # x-pack/jest.config.js
tylersmalley
pushed a commit
that referenced
this pull request
Feb 9, 2021
* [CI] Combines Jest unit tests (#89948) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # jest.config.oss.js # src/dev/code_coverage/shell_scripts/extract_archives.sh # test/scripts/jenkins_unit.sh # test/scripts/jenkins_xpack.sh # vars/kibanaCoverage.groovy # x-pack/jest.config.js * Fix bad merge Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-do of #85850. It was reverted as we thought it was the cause of Jest instability, however, that ended up being caused by resource contention. We are no longer always generating code coverage with this change and will attempt that at a later date.
Previous:
c2-standard-8 - 7 min 57 sec (oss)
c2-standard-8 - 27 min (X-Pack)
c2-standard-8 - 48 min
n2-standard-16 - 32 min