-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use doc link services in index management #89957
Conversation
@elasticmachine merge upstream |
merge conflict between base and head |
a0c3e2a
to
5aca330
Compare
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @lcawl! Index Management has a lot of doc links to cover 😄 .
In the long run, these documentation.ts files should likely be removed and the doc link service called directly instead.
I agree. I started looking into addressing this myself on your branch, but it will require touching a number of files and I think might be more appropriate to address as a separate PR. I can open up an issue to track this work.
I also noticed there are still a handful of hard-coded links generated using esDocsBath
(it looks confined to the step_
components - step_aliases
, step_settings
, step_mappings
). Should these be added to the core doc links service as well?
x-pack/plugins/index_management/public/application/services/documentation.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
merge conflict between base and head |
…cumentation.ts Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
Yes, good catch. I added keywords for those hard-coded links in the core doc link service, but haven't updated the TSX files to use them. It seems to me that would make sense to do after this app is using the core doc link service in general. If you disagree, let me know and I can add that to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-pack/plugins/index_management/public/application/services/documentation.ts
Show resolved
Hide resolved
@elasticmachine update branch |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
Summary
Related to #88107
This PR removes hard-coded links from x-pack/plugins/index_management/public/application/components/component_templates/lib/documentation.ts and x-pack/plugins/index_management/public/application/services/documentation.ts, replacing them with keywords from the documentation link service.
In the long run, these documentation.ts files should likely be removed and the doc link service called directly instead.