Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Sync tooltip legend values in dashboard #90036

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

nickofthyme
Copy link
Contributor

Summary

Fixes #89306

Patches elastic/elastic-charts#993 from elastic charts. See elastic/elastic-charts@v24.4.0...v24.4.1 for details.

Before

Screen Recording 2021-01-26 at 11 27 AM

After

Screen Recording 2021-02-02 at 10 16 AM

Notice the legend values now being updated from the external tooltip event on the dependent chart.

@nickofthyme nickofthyme added regression dependencies Pull requests that update a dependency file v7.11.1 labels Feb 2, 2021
@nickofthyme
Copy link
Contributor Author

@wylieconlon could you confirm this solves the issue when you have a minute? Thanks.

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested on this branch that TSVB syncing is working as expected. Please don't merge until after we release 7.11, as it's only release-blocking bugs that should be merged late in the cycle.

Also please make sure the tags and title are appropriate for the changelogs!

@nickofthyme nickofthyme changed the title Fix tsvb chart legend value sync [TSVB] Sync tooltip legend values in dashboard Feb 3, 2021
@nickofthyme nickofthyme added the backport:skip This commit does not require backporting label Feb 3, 2021
@nickofthyme
Copy link
Contributor Author

@elasticmachine merge upstream

@nickofthyme nickofthyme enabled auto-merge (squash) February 10, 2021 16:22
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
kbn-ui-shared-deps.@elastic.js 2.5MB 2.5MB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit d7ddbbe into elastic:7.11 Feb 10, 2021
@nickofthyme nickofthyme deleted the patch-elastic-charts branch February 10, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting dependencies Pull requests that update a dependency file regression release_note:fix v7.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants