Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SearchSource] Deserialize query string options for serverside ES Query #90050

Merged
merged 2 commits into from
Feb 2, 2021
Merged

[SearchSource] Deserialize query string options for serverside ES Query #90050

merged 2 commits into from
Feb 2, 2021

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Feb 2, 2021 •
edited
Loading

Summary

Closes #57012

Related to #88303

In the serverside context, UI Settings are strings. If the object value of the setting is needed, it must be parsed with JSON.parse.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan requested a review from a team as a code owner February 2, 2021 17:27
@tsullivan tsullivan added v7.12.0 v7.13.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices v8.0.0 labels Feb 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan tsullivan mentioned this pull request Feb 2, 2021
Merged
16 tasks
ppisljar
ppisljar approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 799.7KB 799.8KB +91.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 0370f6b into elastic:master Feb 2, 2021
@tsullivan tsullivan deleted the searchsource/query-string-deserialize branch February 2, 2021 20:32
@tsullivan tsullivan mentioned this pull request Feb 2, 2021
Merged
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 2, 2021
@tsullivan
[SearchSource] Deserialize query string options for serverside ES Que…
9c8398b 
…ry (elastic#90050)

* [SearchSource] Deserialize query string options for serverside ES Query

* fix test
tsullivan added a commit that referenced this pull request Feb 2, 2021
@tsullivan
[SearchSource] Deserialize query string options for serverside ES Que…
56b988f 
…ry (#90050) (#90081)

* [SearchSource] Deserialize query string options for serverside ES Query

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:fix v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] Download CSV from Saved Search panel fails if Lucene synthax used
4 participants
@tsullivan @elasticmachine @kibanamachine @ppisljar