-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip xpack functional security management test #90114
Unskip xpack functional security management test #90114
Conversation
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/management·js.security app Management Security navigation Can navigate to create user sectionStandard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/management·js.security app Management Security navigation Can navigate to create user sectionStandard Out
Stack Trace
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this test!
Looks good but got one comment and one question :)
// await testSubjects.setValue('passwordInput', '123456'); | ||
// await testSubjects.setValue('passwordConfirmationInput', '123456'); | ||
// await testSubjects.setValue('userFormFullNameInput', 'Full User Name'); | ||
// await testSubjects.setValue('userFormEmailInput', 'example@example.com'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove all the comments here and below the call to createUsers
.
We can use git if we ever want to revert.
@@ -148,7 +156,9 @@ export default function ({ getService, getPageObjects }) { | |||
await PageObjects.security.clickSaveEditUser(); | |||
|
|||
await PageObjects.settings.navigateTo(); | |||
await testSubjects.click('users'); | |||
await testSubjects.click('roles'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised this test passes.
Why did you change 'users' to 'roles'? Shouldn't we check that the newly created user appears on the user listing page?
closing this branch...it was against master but should have been against 7.11 |
Trying to resolve a skipped test #61173