Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Time to Visualize] Remove Panels from URL (#86939) #90247

Merged
merged 3 commits into from
Feb 4, 2021
Merged

[7.x] [Time to Visualize] Remove Panels from URL (#86939) #90247

merged 3 commits into from
Feb 4, 2021

Conversation

ThomThomson
Copy link
Contributor

Backports the following commits to 7.x:

@ThomThomson
[Time to Visualize] Remove Panels from URL (elastic#86939)
5103e2c 
Removed panels from dashboard URLs

Co-authored-by: Ryan Keairns <contactryank@gmail.com>
# Conflicts:
#	test/functional/apps/dashboard/view_edit.ts
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 200 203 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 160.9KB 176.4KB +15.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 295.4KB 299.0KB +3.5KB
kibanaReact 119.4KB 119.4KB +20.0B
total +3.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit c78a5a2 into elastic:7.x Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomThomson @kibanamachine