Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA Geo containment alerts. Remove Geo containment alert experimental config settings and refs #90301

Merged
merged 4 commits into from
Feb 5, 2021
Merged

GA Geo containment alerts. Remove Geo containment alert experimental config settings and refs #90301

merged 4 commits into from
Feb 5, 2021

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Feb 4, 2021 •
edited
Loading

Removes the required config flag for enabling the Geo containment alert in preparation for GA release. Users with Gold+ licenses will see Geo containment alerts as an option without any extra configuration.

Easiest way to test is to:

  1. Remove any previous geo alerting configuration values you have set in your kibana.dev.yml or kibana.yml
  2. Start Kibana and Es dev env
  3. Start trial license
  4. Go to create an alert and confirm Geo containment is now an options without needing to be specifically enabled through config

image

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackAlerts 18.8KB 18.7KB -29.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun mentioned this pull request Feb 4, 2021
Closed
20 tasks
@kindsun kindsun marked this pull request as ready for review February 4, 2021 23:05
@kindsun kindsun requested a review from a team as a code owner February 4, 2021 23:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun kindsun added release_note:feature Makes this part of the condensed release notes and removed release highlight labels Feb 4, 2021
YulNaumenko
YulNaumenko approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

thomasneirynck
thomasneirynck approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kindsun kindsun merged commit 5dee629 into elastic:master Feb 5, 2021
@kindsun kindsun deleted the remove-geo-containment-experimental-flag branch February 5, 2021 17:22
@kindsun kindsun mentioned this pull request Feb 5, 2021
Merged
kindsun pushed a commit that referenced this pull request Feb 5, 2021
[7.x] GA Geo containment alerts. Remove Geo containment alert experim…
f9c405e 
…ental config settings and refs (#90301) (#90467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Alerting release_note:feature Makes this part of the condensed release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kindsun @kibanamachine @elasticmachine @thomasneirynck @YulNaumenko