Getting rid of the x-pack tsconfig refs

[kobelb]

This will yield no performance improvement. Based on my one-off test, prior to this change, it took 310 seconds to build the TS projects; and after the change, it took 310 seconds to build the TS projects.

[kobelb]

/cc @tylersmalley @restrry

[tylersmalley]

I put up #90529 after coming to the same conclusion.

[mshustov]

hm... How did you test the changes? My testing algorithm:
master

1. check out master branch, clean cache: time ./node_modules/.bin/tsc -b x-pack/tsconfig.refs.json tsconfig.refs.json --clean
2. run build for both projects: time ./node_modules/.bin/tsc -b x-pack/tsconfig.refs.json tsconfig.refs.json
   time: real 9m7s
3. check out this branch.
4. merge master
5. resolve conflict, list infra plugin in tsconfig.refs.json.
6. run build for the single project: time ./node_modules/.bin/tsc -b tsconfig.refs.json
   time: real 4m40s

[tylersmalley]

@restrry, not sure how you're seeing such an improvement. It's possible that is correct, or that there is additional caching we're missing like with Babel.

When I was testing, I was running git clean -fdx && yarn kbn bootstrap. I tried separating build_ts_refs from the rest of bootstrap, but everything else was extremely consistent.

[kobelb]

@restrry on both branches, I did the following:

1. Delete this line: https://github.com/elastic/kibana/blob/master/package.json#L60
2. yarn kbn clean
3. yarn kbn bootstrap
4. time node ./scripts/build_ts_refs

[tylersmalley]

@kobelb, I believe you removed kbn:bootstrap from package.json during your test?

[kobelb]

@tylersmalley yup!

[mshustov]

@tylersmalley does yarn kbn clean remove target folders?

[tylersmalley]

@restrry, yeah. It should output those directory locations when you run it.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: ce38d09

Metrics [docs]

✅ unchanged

History

• 💚 Build #104471 succeeded 9449f9d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["auto-backport","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"7627d35443a548037ec5cceb92763be9005e2590\",\"formattedMessage\":\"Getting rid of the x-pack tsconfig refs (#90537)\",\"originalMessage\":\"Getting rid of the x-pack tsconfig refs (#90537)\",\"pullNumber\":90537,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] Getting rid of the x-pack tsconfig refs (#90537)\". kibanamachine:backport/7.x/pr-90537 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1126ms"}
{"level":"info","message":"Adding assignees to #90875: kobelb"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/90875/assignees - 201 in 538ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/90875/labels - 200 in 401ms"}
View pull request: https://github.com/elastic/kibana/pull/90875