Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Keyboard-selected items follow user traversal of drop zones #90546

Merged
merged 15 commits into from
Feb 15, 2021
Merged

[Lens] Keyboard-selected items follow user traversal of drop zones #90546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e19f9ad
adding a ghost image
mbondyra Feb 6, 2021
a2f1c14
fix safari fullscreen
mbondyra Feb 9, 2021
97c3393
Merge branch 'master' into lens/dnd_add_ghost_image_to_keyboard_navig…
kibanamachine Feb 9, 2021
464f71c
Merge branch 'master' into lens/dnd_add_ghost_image_to_keyboard_navig…
kibanamachine Feb 9, 2021
548b774
Merge branch 'master' into lens/dnd_add_ghost_image_to_keyboard_navig…
kibanamachine Feb 10, 2021
45dbf89
show ghost instead of noGhost
mbondyra Feb 10, 2021
1c2d223
Merge branch 'master' into lens/dnd_add_ghost_image_to_keyboard_navig…
mbondyra Feb 10, 2021
82c7c22
Merge branch 'master' into lens/dnd_add_ghost_image_to_keyboard_navig…
kibanamachine Feb 11, 2021
c13cfd0
cr corrections
mbondyra Feb 11, 2021
a84ed51
Merge commit '6bd0a7fcc5f477b75ca173ee0de11ebcd2898f4f' into lens/dnd…
mbondyra Feb 11, 2021
7e2d40d
removing commented code
mbondyra Feb 11, 2021
3eb52e6
remvoing commented code
mbondyra Feb 11, 2021
6f60e55
remvoing commented code
mbondyra Feb 11, 2021
2cef3ea
Update x-pack/plugins/lens/public/drag_drop/drag_drop.scss
mbondyra Feb 11, 2021
1f6aa1a
Merge branch 'master' into lens/dnd_add_ghost_image_to_keyboard_navig…
kibanamachine Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions x-pack/plugins/lens/public/drag_drop/__snapshots__/drag_drop.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 31 additions & 5 deletions x-pack/plugins/lens/public/drag_drop/drag_drop.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,21 @@
transition: background-color $euiAnimSpeedFast ease-in-out, border-color $euiAnimSpeedFast ease-in-out;
}

.lnsDragDrop_ghost {
@include lnsDraggable;
border: $euiBorderWidthThin dashed $euiBorderColor;
position: absolute !important; // sass-lint:disable-line no-important
margin: 0 !important; // sass-lint:disable-line no-important
bottom: 100%;
width: 100%;
left: 0;
opacity: .9;
transform: translate(-12px, 8px);
z-index: $euiZLevel2;
pointer-events: none;
box-shadow: 0 0 0 $euiFocusRingSize $euiFocusRingColor;
}

// Draggable item
.lnsDragDrop-isDraggable {
@include lnsDraggable;
Expand Down Expand Up @@ -65,6 +80,7 @@

.lnsDragDrop__container {
position: relative;
overflow: visible !important; // sass-lint:disable-line no-important
}

.lnsDragDrop__reorderableDrop {
Expand All @@ -87,11 +103,6 @@
z-index: $euiZLevel1;
}

// Draggable item when it is moving
.lnsDragDrop-isHidden {
opacity: 0;
}

.lnsDragDrop__keyboardHandler {
top: 0;
position: absolute;
Expand All @@ -105,3 +116,18 @@
pointer-events: none;
}
}

// Draggable item when it is moving
.lnsDragDrop-isHidden {
opacity: 0;
}

.lnsDragDrop-isHidden-noFocus {
opacity: 0;
.lnsDragDrop__keyboardHandler {
&:focus,
&:focus-within {
animation: none;
}
}
}
Loading