Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date histogram time zone for rollup index #90632

Merged
merged 6 commits into from
Feb 15, 2021
Merged

Fix date histogram time zone for rollup index #90632

merged 6 commits into from
Feb 15, 2021

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Feb 8, 2021 •
edited
Loading

Summary

Fixes #90585

This fixes basic visualization (area, line, bar, data table, etc) based on rollup index pattern with Date histogram aggregation.
It seems the regression was caused by #81007. agg.params.field is IndexPatternField type in basic visualizations, but string type in lens

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof marked this pull request as ready for review February 9, 2021 08:15
@sulemanof sulemanof requested a review from a team as a code owner February 9, 2021 08:15
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Feb 9, 2021
ppisljar
ppisljar approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

alexwizp
alexwizp approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some nits

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine for me for both Lens and Visualize.

Can we avoid errors like this to go unnoticed via typing? I would have expected something in the expression building logic to catch it.

@sulemanof sulemanof changed the title Fix/date histogram time zone Fix date histogram time zone for rollup index Feb 15, 2021
@sulemanof sulemanof closed this Feb 15, 2021
@sulemanof sulemanof deleted the fix/date_histogram_time_zone branch February 15, 2021 10:57
@sulemanof sulemanof restored the fix/date_histogram_time_zone branch February 15, 2021 10:58
@sulemanof sulemanof reopened this Feb 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 798.7KB 798.7KB +75.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 6ea2fdc into elastic:master Feb 15, 2021
@sulemanof sulemanof deleted the fix/date_histogram_time_zone branch February 15, 2021 13:13
@sulemanof sulemanof mentioned this pull request Feb 15, 2021
Merged
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Feb 15, 2021
@kibanamachine
Fix date histogram time zone for rollup index (elastic#90632)
baf0e99 
* Fix timezone select

* Add unit test

* Update types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 15, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/update-co…
28ed48d 
…ndition-for-hiding-recommded-allocation

* 'master' of github.com:elastic/kibana:
  [Discover] Fix toggling multi fields from doc view table (elastic#91121)
  [ML] Data Frame Analytics: ROC Curve Chart (elastic#89991)
  skip flaky suite (elastic#86948)
  skip flaky suite (elastic#91191)
  Fix date histogram time zone for rollup index (elastic#90632)
  [Search Source] Fix retrieval of unmapped fields; Add field filters (elastic#89837)
  [Logs UI] Use useMlHref hook for ML links (elastic#90935)
  Fix values of `products.min_price` field in Kibana sample ecommerce data set (elastic#90428)
  [APM] Darker shade for Error group details labels (elastic#91349)
  [Lens] Adjust new copy for 7.12 (elastic#90413)
  [ML] Unskip test. Fix modelMemoryLimit value. (elastic#91280)
  [Lens] Fix empty display name issue in XY chart (elastic#91132)
  [Lens] Improves error messages when in Dashboard (elastic#90668)
  [Lens] Keyboard-selected items follow user traversal of drop zones (elastic#90546)
  [Lens] Improves ranking feature in Top values (elastic#90749)
  [ILM] Rollover min age tooltip and copy fixes (elastic#91110)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts
sulemanof pushed a commit that referenced this pull request Feb 16, 2021
@kibanamachine
Fix date histogram time zone for rollup index (#90632) (#91400)
52a3ad9 
* Fix timezone select

* Add unit test

* Update types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@ppisljar ppisljar ppisljar approved these changes

@flash1293 flash1293 flash1293 approved these changes

@stratoula stratoula Awaiting requested review from stratoula

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid timezone selection in basic visualizations by rollup index
5 participants
@sulemanof @flash1293 @kibanamachine @ppisljar @alexwizp