Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ILM] Revisit searchable snapshot field after new redesign (#90793) #90937

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

jloleysens
Copy link
Contributor

Backports the following commits to 7.x:

…0793)

* moved searchable snapshot field out of cold phase accordian

* refactor styling to padding top and bottom to get advanced settings drop down to sit flush with side of panel

* Error clearing fix and cosmetic changes

- the error state of the form would not clear correctly if the
  erroring field was unmounted. The logic for clearing form errors
  was also incorrectly using "keys" instead of "values".
- updated the width of wait for snapshot policy field to be the
  same as other fields

* fix hook dependency causing clearError to be called

* slight improvement to component integration test

* re-add singleSelection to snapshot policiy field config

* refactored Phase component API and fixed typo in comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 239.3KB 240.0KB +718.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit ce9ca8e into elastic:7.x Feb 15, 2021
@jloleysens jloleysens deleted the backport/7.x/pr-90793 branch February 15, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants