-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search Sessions] Enable Search Sessions #91097
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transform test changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test changes LGTM - thank you for the ping on this PR, AND for the added functional tests in #90818!
Edit: I'd like to see the user filtering PR merged ahead of this one. We shouldn't turn this on by default until we have the per-user restrictions in place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
* enable search sessions * adjust tests * adjust tests * adjust tests * adjust tests * make order consistent Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Search Sessions] Enable Search Sessions (#91097) * enable search sessions * adjust tests * adjust tests * adjust tests * adjust tests * make order consistent Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * adjust tests that is skipped in master and also needs adjustment in master to pass with search sessions Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
❗ Waiting for #84975 merged first
Enables Search Sessions by default
I had to tweak a bunch of feature_controls tests. In the most of the cases changed
global_dashboard_all
->global_dashboard_read
. Those tests are testing the visibility of specific management sections and assertions broke because as per #90818dashboard_all
anddiscover_all
now enable search sessions and search session management becomes available.Release Notes
Search Sessions in Discover and Dashboard are available