Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bootstrap] No longer build TS refs automatically #91234

Closed
wants to merge 18 commits into from

Conversation

tylersmalley
Copy link
Contributor

No description provided.

Tyler Smalley added 2 commits February 11, 2021 14:57
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the no-bootstrap-ts-refs branch 6 times, most recently from cdaa599 to 1f6be14 Compare February 12, 2021 00:26
@kibanamachine

This comment has been minimized.

@tylersmalley tylersmalley force-pushed the no-bootstrap-ts-refs branch 2 times, most recently from 39bc006 to bfc379c Compare February 16, 2021 23:11
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 17, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / jest / Jest Tests.packages/kbn-utils/src/path.Default path finder should find a data directory

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).not.toThrow()

Error name:    "Error"
Error message: "ENOENT: no such file or directory, access '/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/data'"

      18 |   it('should find a data directory', () => {
      19 |     const dataPath = getDataPath();
    > 20 |     expect(() => accessSync(dataPath, constants.R_OK)).not.toThrow();
         |                  ^
      21 |   });
      22 | 
      23 |   it('should find a config directory', () => {

      at packages/kbn-utils/src/path/index.test.ts:20:18
      at Object.<anonymous> (node_modules/expect/build/toThrowMatchers.js:83:11)
      at Object.toThrow (node_modules/expect/build/index.js:338:21)
      at Object.<anonymous> (packages/kbn-utils/src/path/index.test.ts:20:60)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-utils/src/path/index.test.ts:20:60)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
beatsManagement 538.5KB 538.5KB +59.0B
indexPatternManagement 555.7KB 555.7KB +46.0B
total +105.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
beatsManagement 128.4KB 128.4KB +71.0B
indexPatternManagement 69.8KB 69.8KB +71.0B
total +142.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 17, 2021
@elastic elastic deleted a comment from kibanamachine Feb 17, 2021
@tylersmalley
Copy link
Contributor Author

Closing in favor of #91234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants