[Search Source] Request date fields explicitly #91478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
reviewed
Feb 16, 2021
| }; | ||
| } | ||
| return fld; | ||
| body.fields = this.getFieldsWithoutSourceFilters(index, body.fields); |
There was a problem hiding this comment.
🎨 body.fields is overwritten in the next line again. This should rather be a local variable.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 17, 2021
* [Search Source] Remove includes when retrieving fields from source * Removing unusded imports * Use exclusion filters to retrieve a list of fields * Exclude _source from fields list * Fix small check in getting the field list * Fixing faulty import * Filter logic * Adding a unit test for maps use case * Updating maps unit & functional test * Add unit test * Move logic for requesting a field list inside search_source * Remove unnecessary mock * Code cleanup as per PR comments * First pass * Revert functionality for search_after * [Search Source] Add date fields with format * Remove unnecessary log from test * Use local variable Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
31 tasks
majagrubic
pushed a commit
that referenced
this pull request
Feb 17, 2021
* [Search Source] Remove includes when retrieving fields from source * Removing unusded imports * Use exclusion filters to retrieve a list of fields * Exclude _source from fields list * Fix small check in getting the field list * Fixing faulty import * Filter logic * Adding a unit test for maps use case * Updating maps unit & functional test * Add unit test * Move logic for requesting a field list inside search_source * Remove unnecessary mock * Code cleanup as per PR comments * First pass * Revert functionality for search_after * [Search Source] Add date fields with format * Remove unnecessary log from test * Use local variable Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
timroes
added
release_note:enhancement
release_note:skip
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed with ES team, to overcome elastic/elasticsearch#67063, Kibana would request an explicit list of date fields, with the corresponding format. This will allow
date_nanosfields to be returned with the appropriate precision.This PR adds this functionality to search source.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers