Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Table] Improve expression with explicit params #91659

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Feb 17, 2021

Summary

Resolves #84209

Update data table interpreter func arguments. Properties were explicitly extracted out of visConfig json to actual arguments
for example:

kibana_table visConfig='{"metric": { "accessor": 1 }, "bucket": { "accessor": 0, "format": { "type": "ip" }}, "perPage": 20, "showTotal": true, etc... }

becomes:

kibana_table metric={vis_dimension 1} bucket={vis_dimension 0 format='ip'} perPage=20 showTotal=true etc...

to_ast function was updated to pass necessary params into expression function. A copy of legacy to_ast was moved into legacy table implementation.
Unit test cases were updated.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof added Feature:Data Table Data table visualization feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0 labels Feb 18, 2021
@sulemanof sulemanof marked this pull request as ready for review February 19, 2021 08:01
@sulemanof sulemanof requested a review from a team February 19, 2021 08:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it locally and works fine. I tested both legacy and new implementation and I also tried to mess up with the saved object and it works as expected 🙂

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTable 74 75 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTable 110.3KB 111.8KB +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 113.8KB 113.9KB +104.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@sulemanof sulemanof merged commit ab8bca4 into elastic:master Feb 22, 2021
@sulemanof sulemanof deleted the feat/data_table_config branch February 22, 2021 13:33
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Feb 22, 2021
* Enhance data table expression

* Fix types and tests

* Leave legacy expression builder for legacy visualization

* Explicitly pass expression function params, update unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sulemanof pushed a commit that referenced this pull request Feb 23, 2021
* Enhance data table expression

* Fix types and tests

* Leave legacy expression builder for legacy visualization

* Explicitly pass expression function params, update unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Table Data table visualization feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataTable] Improve semantics
5 participants