-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Table] Improve expression with explicit params #91659
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested it locally and works fine. I tested both legacy and new implementation and I also tried to mess up with the saved object and it works as expected 🙂
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@elasticmachine run elasticsearch-ci/docs |
* Enhance data table expression * Fix types and tests * Leave legacy expression builder for legacy visualization * Explicitly pass expression function params, update unit tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Enhance data table expression * Fix types and tests * Leave legacy expression builder for legacy visualization * Explicitly pass expression function params, update unit tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Resolves #84209
Update data table interpreter func arguments. Properties were explicitly extracted out of visConfig json to actual arguments
for example:
kibana_table visConfig='{"metric": { "accessor": 1 }, "bucket": { "accessor": 0, "format": { "type": "ip" }}, "perPage": 20, "showTotal": true, etc... }
becomes:
kibana_table metric={vis_dimension 1} bucket={vis_dimension 0 format='ip'} perPage=20 showTotal=true etc...
to_ast
function was updated to pass necessary params into expression function. A copy of legacyto_ast
was moved into legacy table implementation.Unit test cases were updated.
Checklist
Delete any items that are not applicable to this PR.
(https://github.com/elastic/kibana/blob/c29adfef29e921cc447d2a5ed06ac2047ceab552/src/dev/build/tasks/os_packages/docker_generator/resources/bin/kibana-docker)
For maintainers