Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bootstrap] No longer build TS refs automatically #91781

Closed
wants to merge 3 commits into from
Closed

[bootstrap] No longer build TS refs automatically #91781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eb0bb4
[bootstrap] No longer build TS refs automatically
Feb 18, 2021
da7e037
Try Docker
Feb 18, 2021
1204547
Merge branch 'master' into no-bootstrap-ts-refs-2
kibanamachine Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/kbn-pm/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8984,6 +8984,10 @@ const BootstrapCommand = {
_utils_log__WEBPACK_IMPORTED_MODULE_2__["log"].success(`[${project.name}] bootstrap complete`);
}
});

if (!process.env.BUILD_TS_REFS_ON_BOOTSTRAP) {
_utils_log__WEBPACK_IMPORTED_MODULE_2__["log"].info('For IDE TypeScript support run `node scripts/build_ts_refs` or set BUILD_TS_REFS_ON_BOOTSTRAP=true');
}
}

};
Expand Down
6 changes: 6 additions & 0 deletions packages/kbn-pm/src/commands/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,11 @@ export const BootstrapCommand: ICommand = {
log.success(`[${project.name}] bootstrap complete`);
}
});

if (!process.env.BUILD_TS_REFS_ON_BOOTSTRAP) {
log.info(
'For IDE TypeScript support run `node scripts/build_ts_refs` or set BUILD_TS_REFS_ON_BOOTSTRAP=true'
);
}
},
};
7 changes: 6 additions & 1 deletion scripts/build_ts_refs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,9 @@
*/

require('../src/setup_node_env');
require('../src/dev/typescript').runBuildRefsCli();

if (!process.env.npm_lifecycle_event || process.env.BUILD_TS_REFS_ON_BOOTSTRAP) {
require('../src/dev/typescript').runBuildRefsCli();
} else {
console.warn('ran from yarn script without env BUILD_TS_REFS_ON_BOOTSTRAP=true');
}
6 changes: 6 additions & 0 deletions test/scripts/jenkins_build_ts_refs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env bash

source src/dev/ci_setup/setup_env.sh

checks-reporter-with-killswitch "Build Typescript References" \
node scripts/build_ts_refs.js
1 change: 1 addition & 0 deletions vars/tasks.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def check() {
kibanaPipeline.scriptTask('Verify NOTICE', 'test/scripts/checks/verify_notice.sh'),
kibanaPipeline.scriptTask('Test Projects', 'test/scripts/checks/test_projects.sh'),
kibanaPipeline.scriptTask('Test Hardening', 'test/scripts/checks/test_hardening.sh'),
kibanaPipeline.scriptTaskDocker('Build Typescript References', 'test/scripts/jenkins_build_ts_refs.sh'),
])
}

Expand Down