Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Show mini histograms by default if row count below threshold. #92021

Merged
merged 8 commits into from
Feb 23, 2021
Merged

[ML] Show mini histograms by default if row count below threshold. #92021

merged 8 commits into from
Feb 23, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Feb 19, 2021 •
edited
Loading

Summary

Part of #71231.

Show mini histograms by default if row count below threshold of 10000 docs.

Checklist

For maintainers

@walterra walterra added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms Feature:Data Frame Analytics ML data frame analytics features v7.12.0 Feature:ML Rule Security Solution ML Rule feature labels Feb 19, 2021
@walterra walterra self-assigned this Feb 19, 2021
@walterra walterra mentioned this pull request Feb 22, 2021
Open
13 tasks
@walterra walterra marked this pull request as ready for review February 22, 2021 09:51
@walterra walterra requested a review from a team as a code owner February 22, 2021 09:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@qn895
Copy link
Member

qn895 commented Feb 23, 2021

Tested and everything looks good aside from the saved search (with <10000 docs) not enabling it.

@walterra
Copy link
Contributor Author

@peteharverson @qn895 Was able to fix the issue with saved searches. The problem was that the saved search was initialized asynchronously and the page started with a match_all query which was used for the flag to set charts visibility (which is only set once). The fix also avoids now the unnecessary call to fetch data on load with match_all.

peteharverson
peteharverson approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM

@qn895
Copy link
Member

qn895 commented Feb 23, 2021

LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +1.7KB
transform 943.8KB 944.1KB +300.0B
total +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 68.0KB 68.5KB +477.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 23, 2021
@walterra walterra merged commit 45155f0 into elastic:master Feb 23, 2021
@walterra walterra deleted the ml-fix-histograms branch February 23, 2021 16:35
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@walterra @kibanamachine
[ML] Show mini histograms by default if row count below threshold. (e…
c3ebdc1 
…lastic#92021)

Show mini histograms by default if row count below threshold of 10000 docs.
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@walterra @kibanamachine
[ML] Show mini histograms by default if row count below threshold. (e…
3416932 
…lastic#92021)

Show mini histograms by default if row count below threshold of 10000 docs.
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #92457
✅ 7.x / #92458

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @walterra
[ML] Show mini histograms by default if row count below threshold. (#…
3e98df9 
…92021) (#92457)

Show mini histograms by default if row count below threshold of 10000 docs.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @walterra
[ML] Show mini histograms by default if row count below threshold. (#…
27076ca 
…92021) (#92458)

Show mini histograms by default if row count below threshold of 10000 docs.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Frame Analytics ML data frame analytics features Feature:ML Rule Security Solution ML Rule feature Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @qn895 @kibanamachine @peteharverson