Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting][Docs] Updating docs for notify only on action group change #92084

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 19, 2021

Resolves #90009

Summary

  • Adds docs for this PR
  • Updated some the screenshots for the create alert flyout.

@ymao1 ymao1 requested a review from a team as a code owner February 19, 2021 20:44
@ymao1 ymao1 self-assigned this Feb 19, 2021
@ymao1 ymao1 added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.13.0 v8.0.0 labels Feb 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 requested a review from gchaps February 19, 2021 20:47
@ymao1 ymao1 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 19, 2021
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, otherwise LGTM.

docs/user/alerting/defining-alerts.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/defining-alerts.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/user/alerting/defining-alerts.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 22, 2021
@ymao1 ymao1 merged commit 192f19e into elastic:master Feb 22, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
…elastic#92084)

* Updating docs for notify only on state change

* PR fixes

* Update docs/user/alerting/defining-alerts.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
…elastic#92084)

* Updating docs for notify only on state change

* PR fixes

* Update docs/user/alerting/defining-alerts.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.11 / #92229
7.12 / #92230
7.x / #92231

Successful backport PRs will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
…elastic#92084)

* Updating docs for notify only on state change

* PR fixes

* Update docs/user/alerting/defining-alerts.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 22, 2021
…#92084) (#92230)

* Updating docs for notify only on state change

* PR fixes

* Update docs/user/alerting/defining-alerts.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 22, 2021
…#92084) (#92229)

* Updating docs for notify only on state change

* PR fixes

* Update docs/user/alerting/defining-alerts.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 22, 2021
…#92084) (#92231)

* Updating docs for notify only on state change

* PR fixes

* Update docs/user/alerting/defining-alerts.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@ymao1 ymao1 deleted the alerting/notify-every-docs branch March 25, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch-up release documentation - @ymao1
6 participants