Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics: adds api integration tests for job creation #92101

Merged
merged 2 commits into from
Feb 22, 2021
Merged

[ML] Data Frame Analytics: adds api integration tests for job creation #92101

merged 2 commits into from
Feb 22, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Feb 19, 2021 •
edited
Loading

Summary

Adds integration tests for analytics creation endpoint.

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 19, 2021
pheyos
pheyos approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Just one nit.

x-pack/test/api_integration/apis/ml/data_frame_analytics/create_job.ts Outdated Show resolved Hide resolved
@peteharverson peteharverson mentioned this pull request Feb 22, 2021
Closed
90 tasks
peteharverson
peteharverson approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #108202 succeeded cc07272c61e92a84398573fe01ca7fa672162eb0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit c0de668 into elastic:master Feb 22, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 22, 2021
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Feb 22, 2021
@alvarezmelissa87
[ML] Data Frame Analytics: adds api integration tests for job creation (
bb3d83f 
elastic#92101)

* add create endpoint integration tests

* update test suite name
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 22, 2021
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-api-integration-test branch February 22, 2021 18:53
alvarezmelissa87 added a commit that referenced this pull request Feb 22, 2021
@alvarezmelissa87
[ML] Data Frame Analytics: adds api integration tests for job creation (
81e4883 
#92101) (#92259)

* add create endpoint integration tests

* update test suite name
alvarezmelissa87 added a commit that referenced this pull request Feb 22, 2021
@alvarezmelissa87
[ML] Data Frame Analytics: adds api integration tests for job creation (
8797fa4 
#92101) (#92257)

* add create endpoint integration tests

* update test suite name
@peteharverson peteharverson mentioned this pull request Feb 23, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alvarezmelissa87 @elasticmachine @kibanamachine @pheyos @peteharverson