[7.x] [Enterprise Search] Migrate shared role mapping components (#91723) #92214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1723) * Initial copy/paste of components * Add types * Add constants * Replace EUI toSentenceCase with lodash startCase EUI has not updated their types to include this util and no one else in Kibana uses it so falling back to the lodash equivalent * Update paths * Fix test * Fix TypeScript issues * Remove ability check for non-federated users * Use Kibana React Router helpers Also cleaned up shared type import * Update comments * Fix failing test Also added new lines to match other places in Kibana * Add i18n * Add tests for smaller components - AddRoleMappingButton - DeleteMappingCallout - RoleSelector * Fix fallbacks When trying to achieve coverage it was impossible to create a state that these fallbacks were ever triggered. It’s my assumption that these were added in ent-search to get around TypeScript errors. Added typings instead. * Add tests for AttributeSelector * Add mocks and testSubj attrs * Add tests for RoleMappingsTable * Fix types When actually implementing these I found that these types were wrong * Refactor for better typing * Remove return type This was causing a TypeScript error and is not needed * Rename interface * Rename more interfaces * PR feedback * Add test for radio checked state * Add false radio assertion to * Update className Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2 tasks
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: