Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint][Admin] Policy response flyout view has scrolling #92265

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[Security Solution][Endpoint][Admin] Policy response flyout view has scrolling #92265

merged 1 commit into from
Feb 23, 2021

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Feb 22, 2021 •
edited
Loading

Summary

  • Fixes a bug where the Endpoint View details > Policy Response flyout did not have scrolling even though there was overflow content

Note: Having a parent div, as opposed to just a fragment, around the EuiFlyoutBody causes the automatic scrolling properties of the EuiFlyoutBody to stop working.

Screenshot:
image

@parkiino parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature v7.12.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Feb 22, 2021
@parkiino parkiino requested a review from a team as a code owner February 22, 2021 19:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@elasticmachine
Copy link
Contributor

Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint)

@parkiino parkiino mentioned this pull request Feb 22, 2021
Closed
kevinlog
kevinlog approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should backport to 7.x and 7.12

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +15.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares
paul-tavares approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add 7.13.0 tag to this PR

@parkiino parkiino merged commit 49dee63 into elastic:master Feb 23, 2021
@parkiino parkiino deleted the bug/policy-response-flyout-scroll-missing branch February 23, 2021 16:07
@parkiino parkiino mentioned this pull request Feb 23, 2021
Merged
parkiino added a commit to parkiino/kibana that referenced this pull request Feb 23, 2021
@parkiino
[Security Solution][Endpoint][Admin] Policy response flyout view has …
1fe9b1b 
…scrolling (elastic#92265)
@parkiino parkiino mentioned this pull request Feb 23, 2021
Merged
parkiino added a commit that referenced this pull request Feb 23, 2021
@parkiino
[Security Solution][Endpoint][Admin] Policy response flyout view has …
978de2c 
…scrolling (#92265) (#92444)
parkiino added a commit that referenced this pull request Feb 23, 2021
@parkiino @kibanamachine
[Security Solution][Endpoint][Admin] Policy response flyout view has …
939457f 
…scrolling (#92265) (#92443)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parkiino @elasticmachine @kibanamachine @kevinlog @paul-tavares