Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for ability to specify custom alert ids #92410

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Add docs for ability to specify custom alert ids #92410

merged 2 commits into from
Feb 23, 2021

Conversation

mikecote
Copy link
Contributor

Part of #90005. Adds docs for #89814.

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 23, 2021
@mikecote mikecote self-assigned this Feb 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote requested review from gchaps and a team February 23, 2021 13:58
gmmorris
gmmorris approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote requested a review from ymao1 February 23, 2021 15:54
ymao1
ymao1 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gchaps
gchaps approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit 6c6636c into elastic:master Feb 23, 2021
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.12: Commit could not be cherrypicked due to conflicts
✅ 7.x / #92445

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 92410

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@mikecote @kibanamachine
Add docs for ability to specify custom alert ids (elastic#92410)
5c0726f 
* Add docs for ability to specify custom alert ids

* Add v1/v4
kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @mikecote
Add docs for ability to specify custom alert ids (#92410) (#92445)
af489c9 
* Add docs for ability to specify custom alert ids

* Add v1/v4

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
pmuellr
pmuellr reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote mentioned this pull request Feb 23, 2021
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Feb 23, 2021
@mikecote
Add docs for ability to specify custom alert ids (elastic#92410)
df0c167 
* Add docs for ability to specify custom alert ids

* Add v1/v4
mikecote added a commit that referenced this pull request Feb 23, 2021
@mikecote
Add docs for ability to specify custom alert ids (#92410) (#92503)
8f6bdc7 
* Add docs for ability to specify custom alert ids

* Add v1/v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr left review comments

@gchaps gchaps gchaps approved these changes

@ymao1 ymao1 ymao1 approved these changes

@gmmorris gmmorris gmmorris approved these changes

Assignees

@mikecote mikecote

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikecote @elasticmachine @kibanamachine @pmuellr @gmmorris @ymao1 @gchaps