Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Detections] Updates warning message when no indices match provided index patterns #93094

Merged
merged 2 commits into from
Mar 2, 2021
Merged

[Security Solution] [Detections] Updates warning message when no indices match provided index patterns #93094

merged 2 commits into from
Mar 2, 2021

Conversation

dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Mar 1, 2021 •
edited
Loading

Summary

updates warning messages and modifies warning message when endpoint security rule is missing index pattern

Endpoint Security rule screenshot: endpoint_security_rule_new_warning_message
New text for other rules: standard_warning_missing_index_pattern

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dhurley14 dhurley14 self-assigned this Mar 1, 2021
@dhurley14 dhurley14 added Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:fix review Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team v7.11.2 v7.12.0 v7.13.0 v8.0.0 labels Mar 1, 2021
@dhurley14 dhurley14 marked this pull request as ready for review March 1, 2021 19:54
@dhurley14 dhurley14 requested a review from a team as a code owner March 1, 2021 19:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dhurley14 dhurley14 changed the title [DRAFT] [Security Solution] [Detections] Updates warning message when no indices match provided index patterns [Security Solution] [Detections] Updates warning message when no indices match provided index patterns Mar 1, 2021
spong
spong approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dhurley14! 🙂

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / adds correctly a filter to the global search bar.SearchBar adds correctly a filter to the global search bar

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/69595

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="comboBoxOptionsList filterFieldSuggestionList-optionsList"] button[title="host.ip"] mark`, but never found it.
    at Object.fillAddFilterForm (http://localhost:6121/__cypress/tests?p=cypress/integration/header/search_bar.spec.ts:15733:8)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/header/search_bar.spec.ts:15036:22)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

@peluja1012 peluja1012 requested a review from a team March 2, 2021 10:03
@dhurley14 dhurley14 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021
@dhurley14 dhurley14 merged commit 1bdf002 into elastic:master Mar 2, 2021
@dhurley14 dhurley14 deleted the rule-warning-status-message branch March 2, 2021 14:11
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@dhurley14 @kibanamachine
[Security Solution] [Detections] Updates warning message when no indi…
253fd22 
…ces match provided index patterns (elastic#93094)

* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@dhurley14 @kibanamachine
[Security Solution] [Detections] Updates warning message when no indi…
8a59206 
…ces match provided index patterns (elastic#93094)

* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.11: Commit could not be cherrypicked due to conflicts
✅ 7.12 / #93221
✅ 7.x / #93223

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 93094

dhurley14 added a commit to dhurley14/kibana that referenced this pull request Mar 2, 2021
@dhurley14
[Security Solution] [Detections] Updates warning message when no indi…
76879d6 
…ces match provided index patterns (elastic#93094)

* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text
# Conflicts:
#	x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts
@dhurley14 dhurley14 mentioned this pull request Mar 2, 2021
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
0a85947 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana:
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150)
  Cleanup Security plugin imports (elastic#93056)
  [Security Solution] - Bug fixes (elastic#92294)
  Updated doc links (elastic#92968)
  [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028)
  [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @dhurley14
[Security Solution] [Detections] Updates warning message when no indi…
50ce337 
…ces match provided index patterns (#93094) (#93223)

* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @dhurley14
[Security Solution] [Detections] Updates warning message when no indi…
f77dfbe 
…ces match provided index patterns (#93094) (#93221)

* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
88098e3 
* master: (199 commits)
  Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969)
  [Bazel] More resilient Workspace Status (elastic#93244)
  [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001)
  [Workplace Search] Role Mappings to Kibana (elastic#93123)
  [Fleet] Use type-only imports where possible (elastic#92979)
  [Lens] Set pie chart slices sorted clockwise (elastic#92617)
  Remove ms label from CPU load on status page (elastic#92836)
  [App Search] Migrate Create Meta Engine View (elastic#92127)
  [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917)
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  ...
dhurley14 added a commit that referenced this pull request Mar 2, 2021
@dhurley14
[7.11] [Security Solution] [Detections] Updates warning message when …
44bc123 
…no indices match provided index patterns (#93094) (#93227)

* [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (#93094)

* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text
# Conflicts:
#	x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts

* fix ftr test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@dhurley14 dhurley14

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:fix review Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.2 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhurley14 @elasticmachine @kibanamachine @spong