-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workplace Search] Role Mappings to Kibana #93123
Merged
scottybollinger
merged 23 commits into
elastic:master
from
scottybollinger:scottybollinger/ws-role-mapping
Mar 2, 2021
Merged
[Workplace Search] Role Mappings to Kibana #93123
scottybollinger
merged 23 commits into
elastic:master
from
scottybollinger:scottybollinger/ws-role-mapping
Mar 2, 2021
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for da54c6f - Browse repository at this point
Copy the full SHA da54c6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08d2ce6 - Browse repository at this point
Copy the full SHA 08d2ce6View commit details -
- Update all paths - Change router to use children instead of render props - Remove legacy app chrome
Configuration menu - View commit details
-
Copy full SHA for 45e1e21 - Browse repository at this point
Copy the full SHA 45e1e21View commit details -
- Update all paths - Use global flash messages
Configuration menu - View commit details
-
Copy full SHA for 102e471 - Browse repository at this point
Copy the full SHA 102e471View commit details -
- Update all paths - Use global flash messages - Add types to fix errors - Use React Router Hooks instead of legacy withRouter HOC
Configuration menu - View commit details
-
Copy full SHA for ca191b1 - Browse repository at this point
Copy the full SHA ca191b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ddaceb - Browse repository at this point
Copy the full SHA 7ddacebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85678e1 - Browse repository at this point
Copy the full SHA 85678e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 969ec35 - Browse repository at this point
Copy the full SHA 969ec35View commit details -
Configuration menu - View commit details
-
Copy full SHA for b07a2e0 - Browse repository at this point
Copy the full SHA b07a2e0View commit details -
This is not needed because the ID is actually passed in the URL itself and is not a requirement in the body of the request
Configuration menu - View commit details
-
Copy full SHA for b9450ec - Browse repository at this point
Copy the full SHA b9450ecView commit details -
Replace contextual flash messages with global
It appeared that the server sometimes sent flash messages with the API response, but I checked the Rails server code and there is no `flashMessages` sent back from the server so I am omitting that from the `RoleMappingsServerDetails` interface as well.
Configuration menu - View commit details
-
Copy full SHA for d88a1db - Browse repository at this point
Copy the full SHA d88a1dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac949ed - Browse repository at this point
Copy the full SHA ac949edView commit details -
Configuration menu - View commit details
-
Copy full SHA for c617848 - Browse repository at this point
Copy the full SHA c617848View commit details -
Configuration menu - View commit details
-
Copy full SHA for 154cf03 - Browse repository at this point
Copy the full SHA 154cf03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 708b8e8 - Browse repository at this point
Copy the full SHA 708b8e8View commit details -
Update flash messages in RoleMapping
I did this for RoleMappings but forgot this one
Configuration menu - View commit details
-
Copy full SHA for ebed050 - Browse repository at this point
Copy the full SHA ebed050View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30dfcb7 - Browse repository at this point
Copy the full SHA 30dfcb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 710ea6b - Browse repository at this point
Copy the full SHA 710ea6bView commit details
Commits on Feb 25, 2021
-
Because the shared role mapping components work for both App Search and Workplace Search, the more generic string is used here because App Search has different role names.
Configuration menu - View commit details
-
Copy full SHA for d1b2051 - Browse repository at this point
Copy the full SHA d1b2051View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6aa01f - Browse repository at this point
Copy the full SHA d6aa01fView commit details
Commits on Mar 1, 2021
-
In the case of a new role mapping, the server is called at the ‘/new’ route and the server responds without a roleMapping prop, as it has not yet been created.
Configuration menu - View commit details
-
Copy full SHA for fabacae - Browse repository at this point
Copy the full SHA fabacaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65bc917 - Browse repository at this point
Copy the full SHA 65bc917View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9210060 - Browse repository at this point
Copy the full SHA 9210060View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.