Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Role Mappings to Kibana #93123

Merged

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    da54c6f View commit details
    Browse the repository at this point in the history
  2. Initial copy/paste

    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    08d2ce6 View commit details
    Browse the repository at this point in the history
  3. Update RoleMappingsRouter

    - Update all paths
    - Change router to use children instead of render props
    - Remove legacy app chrome
    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    45e1e21 View commit details
    Browse the repository at this point in the history
  4. Update RoleMappings

    - Update all paths
    - Use global flash messages
    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    102e471 View commit details
    Browse the repository at this point in the history
  5. Update RoleMapping

    - Update all paths
    - Use global flash messages
    - Add types to fix errors
    - Use React Router Hooks instead of legacy withRouter HOC
    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ca191b1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7ddaceb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    85678e1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    969ec35 View commit details
    Browse the repository at this point in the history
  9. Add Role type

    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b07a2e0 View commit details
    Browse the repository at this point in the history
  10. Remove ID prop

    This is not needed because the ID is actually passed in the URL itself and is not a requirement in the body of the request
    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b9450ec View commit details
    Browse the repository at this point in the history
  11. Replace contextual flash messages with global

    It appeared that the server sometimes sent flash messages with the API response, but I checked the Rails server code and there is no `flashMessages` sent back from the server so I am omitting that from the `RoleMappingsServerDetails` interface as well.
    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    d88a1db View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ac949ed View commit details
    Browse the repository at this point in the history
  13. Fix route path

    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    c617848 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    154cf03 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    708b8e8 View commit details
    Browse the repository at this point in the history
  16. Update flash messages in RoleMapping

    I did this for RoleMappings but forgot this one
    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ebed050 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    30dfcb7 View commit details
    Browse the repository at this point in the history
  18. Add i18n

    scottybollinger committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    710ea6b View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Fix type issue

    Because the shared role mapping components work for both App Search and Workplace Search, the more generic string is used here because App Search has different role names.
    scottybollinger committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d1b2051 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6aa01f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Add optional to interface

    In the case of a new role mapping, the server is called at the ‘/new’ route and the server responds without a roleMapping prop, as it has not yet been created.
    scottybollinger committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fabacae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65bc917 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9210060 View commit details
    Browse the repository at this point in the history