Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask #93150

Merged

Commits on Mar 1, 2021

  1. ## [Security Solution] Fixes the Customize Event Renderers modal by r…

    …emoving the EuiOverlayMask
    
    Fixes [this issue](elastic#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.
    
    The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](elastic@8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).
    
    This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:
    
    ### Before
    
    ![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)
    
    ### After
    
    ![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)
    
    ### Desk testing
    
    Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:
    
    - Chrome `88.0.4324.192`
    - Firefox `86.0`
    - Safari `14.0.3`
    andrew-goldstein committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    72b3d76 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Configuration menu
    Copy the full SHA
    4943a23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2747322 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e00a677 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9d76c1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    612619d View commit details
    Browse the repository at this point in the history