Use documentation link service for Watcher #93339
Conversation
jrodewig
added
Feature:Watcher
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
| [ACTION_TYPES.SLACK]: `${links.watcher.slackAction}`, | ||
| [ACTION_TYPES.PAGERDUTY]: `${links.watcher.pagerDutyAction}`, | ||
| [ACTION_TYPES.JIRA]: `${links.watcher.jiraAction}`, |
There was a problem hiding this comment.
i noticed when testing this that the #configuring-x hash was removed from the end of the URL after these changes were applied. Do you think we should re-add them @jrodewig ?
There was a problem hiding this comment.
Thanks @jloleysens. This is intentional. I think the links are better without the anchor. The intro of each action page contains requirements that apply to both UI and API users. For example, in the Slack action docs:
Linking to the #configuring-x "skips" this intro. The #configuring-x sections just provide an API equivalent of the UI configuration. I don't think it'll be helpful to UI users in most cases.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Thanks for explaining the decision to remove the hash in the URLs @jrodewig . Happy for these changes to be merged.
|
Thanks @jloleysens! |
Summary
Relates to #88107
This PR replaces hard-coded links with keywords from the documentation link service.
CC @lcawl
Screenshot
The links are used in the Watcher UI in places like this: