Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Move exceptions builder to lists plugin #94002

Merged
merged 3 commits into from
Mar 9, 2021
Merged

[Security Solution] Move exceptions builder to lists plugin #94002

merged 3 commits into from
Mar 9, 2021

Conversation

marshallmain
Copy link
Contributor

@marshallmain marshallmain commented Mar 8, 2021 •
edited
Loading

Summary

This PR moves exception builder logic for non-value list exceptions to the lists plugin. There should be no changes to functionality in this PR. The purpose is to allow other plugins to use exceptions logic without depending on the security_solution plugin.

Next steps:

  • Move value list exception logic to lists plugin

For maintainers

@marshallmain marshallmain requested review from a team as code owners March 8, 2021 21:04
@marshallmain marshallmain added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team v7.13.0 v8.0.0 labels Mar 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@marshallmain
Copy link
Contributor Author

@elasticmachine merge upstream

@marshallmain
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 131 134 +3
securitySolution 2204 2203 -1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB -3.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 145.2KB 149.4KB +4.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yctercero
yctercero reviewed Mar 9, 2021
View reviewed changes
x-pack/plugins/security_solution/common/detection_engine/get_query_filter.ts
@@ -16,7 +16,7 @@ import {
CreateExceptionListItemSchema,
} from '../../../lists/common/schemas';
import { ESBoolQuery } from '../typed_json';
import { buildExceptionFilter } from './build_exceptions_filter';
import { buildExceptionFilter } from '../shared_imports';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make more things available through the plugin so for example here we'd use the lists client and do something like lists.queryBuilder. Just a thought, nothing to do in this PR.

yctercero
yctercero approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pulled down and tested basic exceptions functionality works ✅

@marshallmain marshallmain added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 9, 2021
@marshallmain marshallmain merged commit 3992ed1 into elastic:master Mar 9, 2021
@marshallmain marshallmain deleted the move-exceptions-part1 branch March 9, 2021 21:39
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 9, 2021
@marshallmain @kibanamachine
Move exceptions builder to lists plugin (elastic#94002)
1015d8b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #94211

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 9, 2021
@kibanamachine @marshallmain
Move exceptions builder to lists plugin (#94002) (#94211)
d70dae9 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
@spong spong mentioned this pull request Mar 11, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marshallmain @elasticmachine @kibanamachine @yctercero