[RAC][Alerts as Data] Adds RAC plugin #94663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuellr
reviewed
Mar 22, 2021
| }, | ||
| }, | ||
| }, | ||
| parents: { |
There was a problem hiding this comment.
should this be a nested type? I'd guess that parent is the direct parent, and that there could be other "indirect" parents? Or just one?
| }, | ||
| }, | ||
| }, | ||
| ancestors: { |
There was a problem hiding this comment.
same question re: parents - should this be nested? Could there be multiple in here?
| field: { | ||
| type: 'keyword', | ||
| }, | ||
| value: { |
There was a problem hiding this comment.
we've not added a notion of a fixed type for thresholds, because "IT depends". The index threshold has comparators "between" and "not between" which take two threshold values. The geo containment alert threshold is some geo-related value - I believe a shape, but perhaps it's a set of points, or ??? - it's unlikely to be captured as a float though.
|
Thank you for the 👀's @pmuellr! In discussing with @dgieselaar today I'm going to remove the index/mapping bootstraping logic from this PR and integrate with the rule-registry (once merged). That said, your comments are still valid, and we'll need to decide about |
⏳ Build in-progress, with failures
Failed CI Steps
History
To update your PR or re-run it, just comment with: |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner validates params before executing the alert typeStandard OutStack TraceKibana Pipeline / jest / Jest Tests.x-pack/plugins/event_log/server/es.createIndexTemplate should throw error if index template still doesn't exist after error is thrownStandard OutStack TraceKibana Pipeline / jest / Jest Tests.x-pack/plugins/apm/server/lib/alerts.Transaction duration anomaly alert doesn't send alert ml is not definedStandard OutStack Traceand 12 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
This PoC is on pause as we integrate the
rule-registry#95903. Reference Rule implementations being iterated on as part of #96015Summary
This is a draft PR for iterating towards the first three
Alerts as Datamilestones:The
RACplugin will act as a test bed while Alerting (#90375) & Detections (#93550) tackle their initial tasks around renaming/modularization. Once suitable implementations are determined for the above we can start integrating modularized pieces like exceptions, monitoring, and begin iterating on API's and other refactoring efforts around rules (supporting alerts as data in remaining Observability rules, breaking out security rules into multiple types, rule management, etc).This initial pass leverages the
event_logmethod of bootstrapping the index, and just needs theexports.EcsEventLogPropertiesupdated to be able to generate the correct mappings using the script:Current progress: