-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Unskip functional test of saved queries #94705
[Discover] Unskip functional test of saved queries #94705
Conversation
started a flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1381/ |
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any idea what caused the flakiness? This test was very flaky when it was skipped so I'm okay unskipping it now with 150 successful runs, but a test that fails every 1000 runs is still flaky enough to skip so I'm not convinced this won't just get skipped again.
@elasticmachine merge upstream |
…-16-unskip-functional-saved-queries-test
…-16-unskip-functional-saved-queries-test
…st' of github.com:kertal/kibana into kertal-pr-2021-03-16-unskip-functional-saved-queries-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to discover possible causes for flakiness!
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
NP, thanks for asking me to dig deeper :) here is the flaky test runner The dependency on previous tests made this test flaky. |
Summary
Unskipped saved queries functional test in Discover, ran a flaky test runner with 150 runs, no errors
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1383/
Fixes #89477
Checklist