Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip functional test of saved queries #94705

Conversation

kertal
Copy link
Member

@kertal kertal commented Mar 16, 2021

Summary

Unskipped saved queries functional test in Discover, ran a flaky test runner with 150 runs, no errors

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1383/

Fixes #89477

Checklist

@kertal kertal marked this pull request as draft March 16, 2021 14:24
@kertal kertal self-assigned this Mar 16, 2021
@kertal kertal added the Feature:Discover Discover Application label Mar 16, 2021
@kertal
Copy link
Member Author

kertal commented Mar 18, 2021

@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 v7.12.0 labels Mar 18, 2021
@kertal
Copy link
Member Author

kertal commented Mar 18, 2021

@elasticmachine merge upstream

@kertal kertal marked this pull request as ready for review March 18, 2021 19:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested a review from spalger March 18, 2021 19:36
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any idea what caused the flakiness? This test was very flaky when it was skipped so I'm okay unskipping it now with 150 successful runs, but a test that fails every 1000 runs is still flaky enough to skip so I'm not convinced this won't just get skipped again.

@kertal
Copy link
Member Author

kertal commented Mar 22, 2021

@elasticmachine merge upstream

kibanamachine and others added 5 commits March 22, 2021 05:56
…st' of github.com:kertal/kibana into kertal-pr-2021-03-16-unskip-functional-saved-queries-test
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to discover possible causes for flakiness!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal
Copy link
Member Author

kertal commented Mar 25, 2021

Thanks for taking the time to discover possible causes for flakiness!

NP, thanks for asking me to dig deeper :) here is the flaky test runner
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1401/

The dependency on previous tests made this test flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v7.13.0 v8.0.0
Projects
None yet
4 participants