Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics: Fix ROC Curve Chart for binary classification. #94791

Merged
merged 4 commits into from
Mar 20, 2021
Merged

[ML] Data Frame Analytics: Fix ROC Curve Chart for binary classification. #94791

merged 4 commits into from
Mar 20, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 17, 2021 •
edited
Loading

Summary

  • Updates the ROC Curve Chart to show only one line for binary classification.
  • Improves type specs for the evaluate panel's data.

Before:

After:

Checklist

@walterra walterra self-assigned this Mar 17, 2021
@walterra walterra requested a review from a team as a code owner March 17, 2021 12:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Mar 17, 2021 •
edited
Loading

Does ROC Curve chart require all the classes in the job for multi-class jobs?
Binary classification changes LGTM 👌 just making sure these error callouts are expected when filtering classes for multiclass jobs.

image

@walterra
Copy link
Contributor Author

Do you get these messages based on a job config or when doing a search? Maybe we can move this discussion to the meta issue if it's unrelated to the changes in this PR? #90421

@walterra walterra mentioned this pull request Mar 18, 2021
Open
7 tasks
alvarezmelissa87
alvarezmelissa87 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +437.0B
transform 907.8KB 907.7KB -26.0B
total +411.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 20, 2021
@walterra walterra merged commit dd7ea1d into elastic:master Mar 20, 2021
@walterra walterra deleted the ml-fix-binary-roc-curve branch March 20, 2021 17:41
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 20, 2021
@walterra @kibanamachine
[ML] Data Frame Analytics: Fix ROC Curve Chart for binary classificat…
d3a8b6c 
…ion. (elastic#94791)

- Updates the ROC Curve Chart to show only one line for binary classification.
- Improves type specs for the evaluate panel's data.
@kibanamachine kibanamachine mentioned this pull request Mar 20, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95020

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 20, 2021
@kibanamachine @walterra
[ML] Data Frame Analytics: Fix ROC Curve Chart for binary classificat…
d6fd548 
…ion. (#94791) (#95020)

- Updates the ROC Curve Chart to show only one line for binary classification.
- Improves type specs for the evaluate panel's data.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Frame Analytics ML data frame analytics features :ml release_note:enhancement v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @alvarezmelissa87 @kibanamachine @peteharverson