-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove bluebird from deps #95191
Closed
Closed
remove bluebird from deps #95191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.13.0
labels
Mar 23, 2021
37 tasks
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/smoke_test·js.Canvas app smoke test renders elements on workpadStandard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/data_shared_attributes·ts.dashboard app using current data dashboard data-shared attributes "before all" hook for "should have time picker with data-shared-timefilter-duration"Standard Out
Stack Trace
Kibana Pipeline / general / Closes and opens alerts.Closing alerts Closes and opens alertsStack Trace
and 2 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Closing as the amount of work to get this done is bigger than I've expected and we havent prioratized working on this. I was doing it outside of working hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to reduce the bundle sizes for both server and public sides of kibana we are removing some redundant packages that we have in the codebase (Context: #88678). Native promises offer all we need and bring a close (and sometimes better) performance.
The package
bluebird
was mostly used in tests. At runtimebluebird
is only used in the following files:Timelion: (replaced with
Promise.all
)Fleet: (replaced with
p-map
)Monitoring: (replaced with
Promise.all
)Security solution: (replaced with
p-map
)