Use documentation link service for runtime fields #95256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
release_note:skip
alisonelizabeth
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Thanks for working on this @lcawl! I left one comment about the tests for ES-UI, but otherwise LGTM. I'm going to go ahead and approve to unblock you, but let me know if you'd like me to take a look again after the change.
...ication/components/mappings_editor/__jest__/client_integration/helpers/setup_environment.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
Bamieh
approved these changes
Mar 26, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Mar 26, 2021
lcawl
added a commit
that referenced
this pull request
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #88107
This PR fixes a broken link (https://www.elastic.co/guide/en/elasticsearch/reference/master/runtime.html#runtime-mapping-fields is an invalid anchor) and switches to using keywords from the documentation link service so that broken links are found more quickly.
In the long term, this documentation.ts can likely be removed and the doc link service can be called directly instead.