Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Fix broken icon in Global Search #95367

Merged
merged 1 commit into from
Mar 25, 2021
Merged

[Observability] Fix broken icon in Global Search #95367

merged 1 commit into from
Mar 25, 2021

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented Mar 24, 2021

Summary

Fixes the broken icon in the Global Search entries for the Observability overview page. The EuiIcon reference was not correct.

Screenshot 2021-03-24 at 22 15 51

Before

Screenshot 2021-03-24 at 21 48 34

After

Screenshot 2021-03-24 at 22 25 53

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.0.0 Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 24, 2021
@formgeist formgeist self-assigned this Mar 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist added the release_note:skip Skip the PR/issue when compiling release notes label Mar 24, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 25.9KB 25.9KB -3.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @formgeist

@formgeist formgeist requested a review from a team March 25, 2021 12:10
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@formgeist formgeist merged commit e894ee9 into elastic:master Mar 25, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 25, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95408

This backport PR will be merged automatically after passing CI.

@formgeist formgeist deleted the observability-overview-global-search-entry branch March 25, 2021 13:33
kibanamachine added a commit that referenced this pull request Mar 25, 2021
Co-authored-by: Casper Hübertz <casper@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants