-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Fix broken icon in Global Search #95367
Merged
formgeist
merged 1 commit into
elastic:master
from
formgeist:observability-overview-global-search-entry
Mar 25, 2021
Merged
[Observability] Fix broken icon in Global Search #95367
formgeist
merged 1 commit into
elastic:master
from
formgeist:observability-overview-global-search-entry
Mar 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formgeist
added
bug
Fixes for quality problems that affect the customer experience
Team:APM
All issues that need APM UI Team support
v8.0.0
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
v7.13.0
auto-backport
Deprecated - use backport:version if exact versions are needed
labels
Mar 24, 2021
Pinging @elastic/apm-ui (Team:apm) |
formgeist
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Mar 24, 2021
💚 Build SucceededMetrics [docs]Page load bundle
To update your PR or re-run it, just comment with: cc @formgeist |
cauemarcondes
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 25, 2021
kibanamachine
added a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken icon in the Global Search entries for the Observability overview page. The
EuiIcon
reference was not correct.Before
After