Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip histogram hiding test #95759

Merged
merged 2 commits into from
Apr 12, 2021
Merged

[Discover] Unskip histogram hiding test #95759

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9fae79
Harden test and unskip
kertal Mar 30, 2021
21d1a0c
Merge branch 'master' into kertal-pr-2021-03-30-discover-unskip-funct…
kibanamachine Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/functional/apps/discover/_discover_histogram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
};
const testSubjects = getService('testSubjects');
const browser = getService('browser');
const retry = getService('retry');

// FLAKY: https://github.com/elastic/kibana/issues/94532
describe.skip('discover histogram', function describeIndexTests() {
describe('discover histogram', function describeIndexTests() {
before(async () => {
await esArchiver.loadIfNeeded('logstash_functional');
await esArchiver.load('long_window_logstash');
Expand Down Expand Up @@ -107,8 +107,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(false);
await testSubjects.click('discoverChartToggle');
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(true);
await retry.waitFor(`Discover histogram to be displayed`, async () => {
canvasExists = await elasticChart.canvasExists();
return canvasExists;
});

await PageObjects.discover.saveSearch('persisted hidden histogram');
await PageObjects.header.waitUntilLoadingHasFinished();

Expand Down