Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Make bundle smaller #95881

Merged
merged 9 commits into from
Mar 31, 2021
Merged

[Maps] Make bundle smaller #95881

merged 9 commits into from
Mar 31, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Mar 30, 2021 •
edited
Loading

Closes #95868

Reduces the maps-bundle limit to 80kB.

This makes two changes:

  • move css import to the lazy-bundle. This reduces the filesize of the main bundle.
  • import plugin dependencies by the type keyword. This is primarily a cosmetic change, but better shows intent of these imports.

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0 WIP Work in progress labels Mar 30, 2021
@thomasneirynck thomasneirynck marked this pull request as ready for review March 31, 2021 13:34
@thomasneirynck thomasneirynck requested review from a team as code owners March 31, 2021 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@tylersmalley tylersmalley added the release_note:skip Skip the PR/issue when compiling release notes label Mar 31, 2021
tylersmalley
tylersmalley approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limits change LGTM - thanks for jumping on this so quickly!

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Mar 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@thomasneirynck thomasneirynck removed the WIP Work in progress label Mar 31, 2021
@thomasneirynck thomasneirynck changed the title [Maps] Make maps bundle smaller [Maps] Make bundle smaller Mar 31, 2021
nreese
nreese approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review

x-pack/plugins/maps/public/kibana_services.ts Show resolved Hide resolved
spong
spong approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution changes LGTM! Thanks @thomasneirynck! 🙂

shahzad31
shahzad31 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +58.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 125.2KB 66.7KB -58.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 31, 2021
@thomasneirynck thomasneirynck merged commit d2e2209 into elastic:master Mar 31, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.x: Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 95881

@thomasneirynck thomasneirynck mentioned this pull request Apr 1, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Apr 1, 2021
@thomasneirynck
[Maps] Make bundle smaller (elastic#95881)
c1b7874 
# Conflicts:
#	packages/kbn-optimizer/limits.yml
#	x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/embedded_map.tsx
#	x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/map_tool_tip.tsx
thomasneirynck added a commit that referenced this pull request Apr 1, 2021
@thomasneirynck
[Maps] Make bundle smaller (#95881) (#96016)
9e91aea 
# Conflicts:
#	packages/kbn-optimizer/limits.yml
#	x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/embedded_map.tsx
#	x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/map_tool_tip.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@spong spong spong approved these changes

@nreese nreese nreese approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] Reduce page load bundle to under 100kB
7 participants
@thomasneirynck @elasticmachine @kibanamachine @tylersmalley @nreese @spong @shahzad31