Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test user for maps test verifying sample data maps #96109

Merged
merged 20 commits into from
Apr 14, 2021

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Apr 1, 2021

Meta issue - #60815

This PR is doing two things:

  1. Adding test user to sample_data.js test file under maps app
  2. Removing "geoall_data_writer" role from add_layer_import_panel.js file because we don't need it anymore.

@bhavyarm bhavyarm self-assigned this Apr 1, 2021
@bhavyarm bhavyarm added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional labels Apr 1, 2021
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm marked this pull request as ready for review April 12, 2021 20:51
@bhavyarm bhavyarm requested a review from a team as a code owner April 12, 2021 20:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@bhavyarm bhavyarm requested a review from LeeDr April 12, 2021 20:51
@LeeDr
Copy link
Contributor

LeeDr commented Apr 12, 2021

@bhavyarm Are the user docs in alignment with what you're finding in these tests as far as roles or permissions?

@@ -80,15 +89,25 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
await kibanaServer.uiSettings.update({
[UI_SETTINGS.TIMEPICKER_QUICK_RANGES]: SAMPLE_DATA_RANGE,
});
await security.testUser.setRoles(
['global_maps_all', 'geoall_data_writer', 'kibana_sample_admin'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need 'geoall_data_writer' here? It's not clear to me why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we do. If I we don't - we can't add the sample data index patterns.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the sample data was already loaded before this step as the default superuser.

@bhavyarm
Copy link
Contributor Author

@LeeDr yes I saw good error messages on the screen without them.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

For the add_layer_import_panel.js test - if I remove ", 'global_index_pattern_management_all'" - then I see this on UI.
Screen Shot 2021-04-14 at 2 33 37 PM

@nreese
Copy link
Contributor

nreese commented Apr 14, 2021

@bhavyarm Disabling the upload card when users can not create index patterns was recently added. The goal is to fail early in the upload process instead of letting someone upload a file but then not have permissions to create an index pattern. Required permissions are documented at https://www.elastic.co/guide/en/kibana/7.x/import-geospatial-data.html#import-geospatial-privileges

Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Code review and discussed with Bhavya

@bhavyarm
Copy link
Contributor Author

Thanks @nreese

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm merged commit f92ce30 into elastic:master Apr 14, 2021
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Apr 14, 2021
 test user for sample maps test & removing geoall_writer_role from add layer
bhavyarm added a commit that referenced this pull request Apr 15, 2021
test user for sample maps test & removing geoall_writer_role from add layer
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
 test user for sample maps test & removing geoall_writer_role from add layer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants