Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Stabilize Anomaly Explorer embeddable functional tests #96421

Merged
merged 3 commits into from
Apr 8, 2021
Merged

[ML] Stabilize Anomaly Explorer embeddable functional tests #96421

merged 3 commits into from
Apr 8, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Apr 7, 2021 •
edited
Loading

Summary

This PR stabilizes #96202, which was not showing the add panel in the Dashboard in the accessibility tests.

Started flaky test suite runner... Successfully passes after 50 runs ✅

@qn895 qn895 added :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 7, 2021
@qn895 qn895 self-assigned this Apr 7, 2021
@qn895 qn895 changed the title [ML] Stabilize add panel [ML] Stabilize Anomaly Explorer embeddable functional tests Apr 7, 2021
@qn895 qn895 marked this pull request as ready for review April 7, 2021 16:03
@qn895 qn895 requested a review from a team as a code owner April 7, 2021 16:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member Author

qn895 commented Apr 7, 2021

@elasticmachine merge upstream

darnautov
darnautov approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson mentioned this pull request Apr 8, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 8, 2021
@qn895 qn895 merged commit 2582522 into elastic:master Apr 8, 2021
@qn895 qn895 deleted the ml-stabilize-add-panel branch April 8, 2021 16:08
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 8, 2021
@qn895 @kibanamachine
[ML] Stabilize Anomaly Explorer embeddable functional tests (elastic#…
e5df4c4 
…96421)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #96599

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 12, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Apr 12, 2021
@kibanamachine @qn895
[ML] Stabilize Anomaly Explorer embeddable functional tests (#96421) (#…
7b852ba 
…96599)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 12, 2021
@pheyos pheyos mentioned this pull request Apr 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@qn895 qn895

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qn895 @elasticmachine @kibanamachine @darnautov @peteharverson