Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Move remaining HTTP functionality to client #96507
[Cases] Move remaining HTTP functionality to client #96507
Changes from 7 commits
84d1ca7
6ac82ac
f3e47d0
683f50a
a266a08
2008a5f
25b6b5e
e3a95a1
12a705d
0c3c544
bc299ea
c39266b
ab14d32
0207f04
477ad97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about
createCaseError
: are these messages shown to users, including via HTTP responses? If so, I'm wondering if they should be internationalized.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oatkiller That's a good question. Yes, some of them are being shown to the users. I think
i18n
is not supported for the backend. Do you know how to internationalize these messages?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these messages are just logged to the console/some file but some of them do get bubbled up to the user. @XavierM @legrego @kobelb should we internationalize server side error and audit log messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of an official stance, but personally I'd vote to keep them in English. That makes for a consistent auditing, debugging, and triaging experience, and makes searching for solutions based on error messages much easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathan-buttner I don't think we have an official stance, but +1 for keeping them in English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still i18n the messages that are show to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legrego @kobelb @jonathan-buttner @cnasikas I opened a discuss issue about this: #97650