Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Security Solution][Detections]Fixes Rule Management Cypress Tests (#96505) #96521

Merged
merged 1 commit into from
Apr 8, 2021
Merged

[7.x] [Security Solution][Detections]Fixes Rule Management Cypress Tests (#96505) #96521

merged 1 commit into from
Apr 8, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@spong @kibanamachine
[Security Solution][Detections]Fixes Rule Management Cypress Tests (e…
8619e13 
…lastic#96505)

## Summary
Fixes two cypress tests:

> Deleting prebuilt rules "before each" hook for "Does not allow to delete one rule when more than one is selected"
elastic#68607

This one is more of a drive around the pot-hole fix as we were waiting for the Alerts Table to load when we really didn't need to. Removed unnecessary check.
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/113932347-b9ab9480-97b0-11eb-8e07-5f3e0c4b6c78.png" />
</p>

> Alerts rules, prebuilt rules Loads prebuilt rules
elastic#71300

This one was fixed with a `.pipe()` and `.should('not.be.visible')` to ensure the click was successful. Also removed unnecessary check on the Alerts Table loading that was present here as well too..
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/113932285-ac8ea580-97b0-11eb-90e1-618c510d33a7.png" />
</p>
@kibanamachine kibanamachine enabled auto-merge (squash) April 8, 2021 00:59
@kibanamachine kibanamachine mentioned this pull request Apr 8, 2021
Merged
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@kibanamachine kibanamachine merged commit 6af5828 into elastic:7.x Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spong spong

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibanamachine @spong