Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Visualize] Allows editing broken visualizations caused by runtime fields changes (#94798) #96579

Closed
wants to merge 1 commit into from

Conversation

VladLasitsa
Copy link
Contributor

Backports the following commits to 7.x:

…elds changes (elastic#94798)

* Add possibility to open visualization when saved field doesn't exists anymore

* Fix tests

* Fix some remarks

* Remove unneeded code

* Fix tests

* Fix tests

* Fix some remarks

* Fixed problem with double error popover in visualizations

* Fix CI

* Fix type

* Fix API docs

* Don't show error popup for error related to runtime fields

* Fix some remarks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@VladLasitsa VladLasitsa enabled auto-merge (squash) April 8, 2021 14:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visDefaultEditor 225.7KB 226.7KB +1004.0B
visualize 91.4KB 91.8KB +416.0B
total +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 788.0KB 788.7KB +756.0B
embeddable 155.7KB 155.7KB -66.0B
kibanaUtils 143.1KB 143.8KB +687.0B
visualizations 91.8KB 91.9KB +3.0B
visualize 26.7KB 27.0KB +238.0B
total +1.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

The backport for this PR have already merged.

@VladLasitsa VladLasitsa closed this Apr 8, 2021
auto-merge was automatically disabled April 8, 2021 21:23

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants