Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12] [Security Solution] Fixes the Read Less button rendering below the fold (#96524) #96635

Merged

Conversation

andrew-goldstein
Copy link
Contributor

Backports the following commits to 7.12:

…fold (elastic#96524)

## [Security Solution] Fixes the `Read Less` button rendering below the fold

Fixes issue <elastic#95295> where the `Read Less` button in the Event Details flyout is rendered below the fold when an event's `message` field is too large, per the `Before` and `After` screenshots below:

### Before

![before](https://user-images.githubusercontent.com/4459398/113962310-aa463e80-97e4-11eb-93f9-f4a90bd250f6.png)

_Before: The `Read Less` button is not visible in the `Event details` flyout above_

### After

![after](https://user-images.githubusercontent.com/4459398/113962433-e9748f80-97e4-11eb-8f46-835eb12ea09d.png)

_After: The `Read Less` button is visible in the `Event details` flyout above_

In the _After_ screenshot above, the long `message` is rendered in a vertically scrollable view that occupies ~ one third of the vertical height of the viewport. The `Read Less` button is visible below the message.

### Desk Testing

Desk tested on a 16" MBP, and at larger desktop resolutions in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
@andrew-goldstein andrew-goldstein enabled auto-merge (squash) April 8, 2021 19:05
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +411.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants