Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB][performance] remove visPayloadSchema.validate #97091

Merged
merged 2 commits into from
Apr 14, 2021
Merged

[TSVB][performance] remove visPayloadSchema.validate #97091

merged 2 commits into from
Apr 14, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 14, 2021 •
edited
Loading

Part of: #97061

Summary

First step of work on #97061 ([TSVB] Improve schema validation performance). For current release we remove visPayloadSchema.validate method execution to fix the performance issues related with calling this method.
Next step will be using TS types instead of visPayloadSchema in TSVB.

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) performance Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 14, 2021
@alexwizp alexwizp self-assigned this Apr 14, 2021
@alexwizp alexwizp marked this pull request as ready for review April 14, 2021 10:48
@alexwizp alexwizp requested a review from a team April 14, 2021 10:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timroes
Copy link
Contributor

timroes commented Apr 14, 2021

@elasticmachine run elasticsearch-ci/docs

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit bcc1acb into elastic:master Apr 14, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 14, 2021
@alexwizp
[TSVB][performance] remove visPayloadSchema.validate (elastic#97091)
cc70aa6 
* [TSVB][performance] remove visPayloadSchema.validate

Part of: elastic#97061

* Update vis.ts
@alexwizp alexwizp mentioned this pull request Apr 14, 2021
Merged
alexwizp added a commit that referenced this pull request Apr 14, 2021
@alexwizp
[TSVB][performance] remove visPayloadSchema.validate (#97091) (#97105)
2693cf5 
* [TSVB][performance] remove visPayloadSchema.validate

Part of: #97061

* Update vis.ts
@mshustov mshustov mentioned this pull request May 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@wylieconlon wylieconlon Awaiting requested review from wylieconlon

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) performance release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @elasticmachine @timroes @kibanamachine @stratoula