-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Better defaults for top values odering #97099
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this works exactly how I expected it to. My only comment is about whether we want to store this in the persisted state vs local state only: if you open a saved visualization that uses a fallback it will have the same state.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
I see the point - I thought it would make sense to persist the flag as well. Let's see whether people get annoyed with it. |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Fixes #87115
This PR changes the default rank behavior of the top values function to make it more likely to pick the desired output without explicit user interaction.
It introduces a new piece of state for a dimension, recording whether it's using alphabetical sorting because the user explicitly chose alphabetical or whether there was no other option
Behaviors: